diff --git a/docs/CHANGES.txt b/docs/CHANGES.txt index f3463a6b..390b3b65 100644 --- a/docs/CHANGES.txt +++ b/docs/CHANGES.txt @@ -1,5 +1,35 @@ CHANGE LOG +2014-03-22 by alderaan +Forum search: Rename "Username" to "Posted by" and add an HTML5 placeholder for the "posted by" text box + +2014-03-22 by alderaan +"ask the staff" tool: improve display of page header + +2014-03-22 by alderaan +Use HTML5 input type "search" for text boxes in search forms + +2014-03-22 by alderaan +Use HTML5's placeholder attribute for the "search inbox" text box + +2014-03-22 by alderaan +Add class="label" to the form labels on the "create a user" page + +2014-03-22 by alderaan +Add missing header for the "invite pool" staff tool page + +2014-03-22 by alderaan +Remove duplicated "economic stats" link on /tools.php + +2014-03-22 by alderaan +Use HTML5 input type "email" for forms that require email address input + +2014-03-22 by alderaan +Move the text box for entering the target torrent group ID into the same row as its label + +2014-03-22 by alderaan +Add a "release type" label for the drop-down menu when editing torrent groups + 2014-03-20 by alderaan Use class="wide_input_text" for the "extra log message" and "extra staff notes" text boxes on the Reports v2 and torrent deletion forms diff --git a/sections/better/transcode.php b/sections/better/transcode.php index 664f6eb1..0b542ce3 100644 --- a/sections/better/transcode.php +++ b/sections/better/transcode.php @@ -90,7 +90,7 @@ - +   diff --git a/sections/better/transcode_beta.php b/sections/better/transcode_beta.php index b6842f7a..33fd985e 100644 --- a/sections/better/transcode_beta.php +++ b/sections/better/transcode_beta.php @@ -255,7 +255,7 @@ function transcode_parse_groups($Groups) { Search - +   diff --git a/sections/collages/browse.php b/sections/collages/browse.php index 777b526f..7a27d7fc 100644 --- a/sections/collages/browse.php +++ b/sections/collages/browse.php @@ -178,7 +178,7 @@ Search terms: - + diff --git a/sections/forums/forum.php b/sections/forums/forum.php index bd0f281e..c88d2ddc 100644 --- a/sections/forums/forum.php +++ b/sections/forums/forum.php @@ -101,7 +101,7 @@ Search for: - + @@ -114,11 +114,13 @@ - Username: - + Posted by: + - + + + diff --git a/sections/forums/search.php b/sections/forums/search.php index dcc3dc5f..f21f512d 100644 --- a/sections/forums/search.php +++ b/sections/forums/search.php @@ -97,13 +97,13 @@ Search for: - + - Username: + Posted by: - + @@ -224,8 +224,8 @@ p.Body, t.CreatedTime FROM forums_posts AS p - JOIN forums_topics AS t ON t.ID=p.TopicID - JOIN forums AS f ON f.ID=t.ForumID + JOIN forums_topics AS t ON t.ID = p.TopicID + JOIN forums AS f ON f.ID = t.ForumID WHERE " . Forums::user_forums_sql() . ' AND '; //In tests, this is significantly faster than LOCATE @@ -238,13 +238,13 @@ //$SQL .= "', p.Body) "; if (isset($SearchForums)) { - $SQL.=" AND f.ID IN ($SearchForums)"; + $SQL .= " AND f.ID IN ($SearchForums)"; } if (isset($AuthorID)) { - $SQL.=" AND p.AuthorID='$AuthorID' "; + $SQL .= " AND p.AuthorID = '$AuthorID' "; } if (!empty($ThreadID)) { - $SQL.=" AND t.ID='$ThreadID' "; + $SQL .= " AND t.ID = '$ThreadID' "; } if (!empty($ThreadAfterDate)) { $SQL .= " AND t.CreatedTime >= '$ThreadAfterDate'"; @@ -276,7 +276,7 @@ '', t.CreatedTime FROM forums_topics AS t - JOIN forums AS f ON f.ID=t.ForumID + JOIN forums AS f ON f.ID = t.ForumID WHERE " . Forums::user_forums_sql() . ' AND '; $SQL .= "t.Title LIKE '%"; $SQL .= implode("%' AND t.Title LIKE '%", $Words); diff --git a/sections/forums/thread.php b/sections/forums/thread.php index 3939d1bf..6eaa9f36 100644 --- a/sections/forums/thread.php +++ b/sections/forums/thread.php @@ -192,11 +192,11 @@ - + - - + + diff --git a/sections/login/recover_step1.php b/sections/login/recover_step1.php index 77e4b965..ed366de4 100644 --- a/sections/login/recover_step1.php +++ b/sections/login/recover_step1.php @@ -14,8 +14,8 @@ An email will be sent to your email address with information on how to reset your password.

Search for:
Username:Posted by:
diff --git a/sections/inbox/inbox.php b/sections/inbox/inbox.php index f1c6aa1a..ec481fbd 100644 --- a/sections/inbox/inbox.php +++ b/sections/inbox/inbox.php @@ -91,9 +91,9 @@
diff --git a/sections/log/index.php b/sections/log/index.php index 02e1b2a4..6ca4d382 100644 --- a/sections/log/index.php +++ b/sections/log/index.php @@ -17,7 +17,7 @@
Search for: - /> + />  
- - + + diff --git a/sections/questions/questions.php b/sections/questions/questions.php index b6902bac..24f772fb 100644 --- a/sections/questions/questions.php +++ b/sections/questions/questions.php @@ -41,12 +41,8 @@ ?>
-

- User Questions - - questions asked, left to answer - -

+

User Questions

+

questions asked; left to answer

- + diff --git a/sections/requests/requests.php b/sections/requests/requests.php index 4211b86c..34d107d0 100644 --- a/sections/requests/requests.php +++ b/sections/requests/requests.php @@ -376,13 +376,13 @@ @@ -403,7 +403,7 @@ diff --git a/sections/tools/data/invite_pool.php b/sections/tools/data/invite_pool.php index 9413fe3d..a639277c 100644 --- a/sections/tools/data/invite_pool.php +++ b/sections/tools/data/invite_pool.php @@ -2,7 +2,8 @@ if (!check_perms('users_view_invites')) { error(403); } -View::show_header('Invite Pool'); +$Title = 'Invite Pool'; +View::show_header($Title); define('INVITES_PER_PAGE', 50); list($Page, $Limit) = Format::page_limit(INVITES_PER_PAGE); @@ -44,6 +45,9 @@ $DB->set_query_id($RS); ?> +
+

+

unused invites have been sent.

@@ -52,10 +56,10 @@
Email Email address: 
Email Email address  - +
Search terms: - +
Tags (comma-separated): - />  + />  />   />
Requested by: - +
- + @@ -72,8 +76,8 @@
Email:Email address: - +  
- - + + diff --git a/sections/tools/development/render_base.html b/sections/tools/development/render_base.html index 95ee6f57..32d5fbf6 100644 --- a/sections/tools/development/render_base.html +++ b/sections/tools/development/render_base.html @@ -76,9 +76,7 @@ id="torrentssearch" accesskey="t" spellcheck="false" - onfocus="if (this.value == 'Torrents') this.value='';" - onblur="if (this.value == '') this.value='Torrents';" - value="Torrents" type="text" name="searchstr" size="17" + placeholder="Torrents" type="search" name="searchstr" size="17" /> @@ -86,39 +84,38 @@ - +
  • - +
  • - +
  • - +
  • - +
  • -
    diff --git a/sections/tools/finances/donation_log.php b/sections/tools/finances/donation_log.php index a14743f8..ad407f6e 100644 --- a/sections/tools/finances/donation_log.php +++ b/sections/tools/finances/donation_log.php @@ -106,19 +106,19 @@
    diff --git a/sections/tools/finances/donor_rewards.php b/sections/tools/finances/donor_rewards.php index 031b0779..fbafe52f 100644 --- a/sections/tools/finances/donor_rewards.php +++ b/sections/tools/finances/donor_rewards.php @@ -50,7 +50,8 @@ - Username Search: + Username Search: +
    InviterEmailIPEmail addressIP address InviteCode Expires
    Username: - +
    Email: - +
    Source: - +
    diff --git a/sections/tools/managers/bans.php b/sections/tools/managers/bans.php index 24b1aca8..efb44f85 100644 --- a/sections/tools/managers/bans.php +++ b/sections/tools/managers/bans.php @@ -95,12 +95,12 @@
    - + - + diff --git a/sections/tools/managers/email_blacklist.php b/sections/tools/managers/email_blacklist.php index 2a4e68d9..ae0f4eac 100644 --- a/sections/tools/managers/email_blacklist.php +++ b/sections/tools/managers/email_blacklist.php @@ -42,8 +42,8 @@
    - - + +
    - + - + @@ -81,7 +81,7 @@ - + diff --git a/sections/tools/managers/email_blacklist_alter.php b/sections/tools/managers/email_blacklist_alter.php index 626f87fe..1637474b 100644 --- a/sections/tools/managers/email_blacklist_alter.php +++ b/sections/tools/managers/email_blacklist_alter.php @@ -5,15 +5,17 @@ authorize(); -if ($_POST['submit'] == 'Delete') { // Delete - if (!is_number($_POST['id']) || $_POST['id'] == '') { +if ($_POST['submit'] === 'Delete') { // Delete + if (!is_number($_POST['id']) || $_POST['id'] === '') { error(0); } - $DB->query('DELETE FROM email_blacklist WHERE ID='.$_POST['id']); + $DB->query(" + DELETE FROM email_blacklist + WHERE ID = $_POST[id]"); } else { // Edit & Create, Shared Validation - $Val->SetFields('email', '1','string','The email must be set', array('minlength'=>1)); - $Val->SetFields('comment', '0','string','The description has a max length of 255 characters', array('maxlength'=>255)); - $Err = $Val->ValidateForm($_POST); // Validate the form + $Val->SetFields('email', '1', 'string', 'The email must be set', array('minlength'=>1)); + $Val->SetFields('comment', '0', 'string', 'The description has a max length of 255 characters', array('maxlength'=>255)); + $Err = $Val->ValidateForm($_POST); if ($Err) { error($Err); } @@ -21,22 +23,22 @@ $P = array(); $P = db_array($_POST); // Sanitize the form - if ($_POST['submit'] == 'Edit') { // Edit - if (!is_number($_POST['id']) || $_POST['id'] == '') { + if ($_POST['submit'] === 'Edit') { // Edit + if (!is_number($_POST['id']) || $_POST['id'] === '') { error(0); } $DB->query(" UPDATE email_blacklist SET - Email='$P[email]', - Comment='$P[comment]', - UserID='$LoggedUser[ID]', - Time='".sqltime()."' - WHERE ID='$P[id]'"); + Email = '$P[email]', + Comment = '$P[comment]', + UserID = '$LoggedUser[ID]', + Time = '".sqltime()."' + WHERE ID = '$P[id]'"); } else { // Create $DB->query(" INSERT INTO email_blacklist (Email, Comment, UserID, Time) - VALUES ('$P[email]','$P[comment]','$LoggedUser[ID]','".sqltime()."')"); + VALUES ('$P[email]', '$P[comment]', '$LoggedUser[ID]', '".sqltime()."')"); } } diff --git a/sections/tools/misc/create_user.php b/sections/tools/misc/create_user.php index f84a7d44..81dc2dc6 100644 --- a/sections/tools/misc/create_user.php +++ b/sections/tools/misc/create_user.php @@ -98,19 +98,21 @@
    EmailEmail address CommentAddedDate added Submit

    - + - - + + - + - +
    Username Username:
    Email Email address:
    Password Password:
    + +
    diff --git a/sections/tools/misc/dupe_ip.php b/sections/tools/misc/dupe_ip.php index 26b620dd..22a36b0f 100644 --- a/sections/tools/misc/dupe_ip.php +++ b/sections/tools/misc/dupe_ip.php @@ -71,10 +71,11 @@
    - +

    There are currently no users with more than IP overlaps.

    - diff --git a/sections/tools/misc/manipulate_tree.php b/sections/tools/misc/manipulate_tree.php index 61d9c388..e3038588 100644 --- a/sections/tools/misc/manipulate_tree.php +++ b/sections/tools/misc/manipulate_tree.php @@ -92,9 +92,9 @@ - + - + diff --git a/sections/tools/tools.php b/sections/tools/tools.php index 9604a379..afdcdc68 100644 --- a/sections/tools/tools.php +++ b/sections/tools/tools.php @@ -178,7 +178,6 @@ function create_row($Title, $URL, $HasPermission = false, $Tooltip = false) { // begin Site Information category $ToolsHTML = ""; create_row("Economic stats", "tools.php?action=economic_stats", check_perms("site_view_flow")); - create_row("Economic stats", "tools.php?action=economic_stats", check_perms("site_view_flow")); create_row("Invite pool", "tools.php?action=invite_pool", check_perms("users_view_invites")); create_row("Registration log", "tools.php?action=registration_log", check_perms("users_view_ips") && check_perms("users_view_email")); diff --git a/sections/torrents/browse.php b/sections/torrents/browse.php index 33ba545e..8aeac711 100644 --- a/sections/torrents/browse.php +++ b/sections/torrents/browse.php @@ -642,29 +642,29 @@ function header_link($SortKey, $DefaultWay = 'desc') { @@ -684,35 +684,35 @@ function header_link($SortKey, $DefaultWay = 'desc') { @@ -780,13 +780,13 @@ function header_link($SortKey, $DefaultWay = 'desc') { diff --git a/sections/torrents/editgroup.php b/sections/torrents/editgroup.php index 37c4b512..d59d89fa 100644 --- a/sections/torrents/editgroup.php +++ b/sections/torrents/editgroup.php @@ -64,13 +64,14 @@

    Torrent group description:


    - $Val) { ?> - + - + + -

    @@ -167,8 +168,9 @@ -

    Target torrent group ID

    - +

    Target torrent group ID: + +

    diff --git a/sections/torrents/user.php b/sections/torrents/user.php index a95cfc99..f6c32626 100644 --- a/sections/torrents/user.php +++ b/sections/torrents/user.php @@ -346,7 +346,7 @@ function header_link($SortKey, $DefaultWay = 'DESC') { @@ -409,7 +409,7 @@ function header_link($SortKey, $DefaultWay = 'DESC') { diff --git a/sections/user/advancedsearch.php b/sections/user/advancedsearch.php index ce6a1ac1..e6ff785c 100644 --- a/sections/user/advancedsearch.php +++ b/sections/user/advancedsearch.php @@ -482,7 +482,7 @@ function num_compare($Field, $Operand, $Num1, $Num2 = '') { - + diff --git a/sections/user/edit.php b/sections/user/edit.php index bb44932f..3be8dc49 100644 --- a/sections/user/edit.php +++ b/sections/user/edit.php @@ -787,7 +787,7 @@ function checked($Checked) { diff --git a/sections/user/invite.php b/sections/user/invite.php index 380ed980..22f94d7c 100644 --- a/sections/user/invite.php +++ b/sections/user/invite.php @@ -151,7 +151,7 @@ @@ -179,7 +179,7 @@
    UserID Mandatory comment!
    Action:
    Artist name: - +
    Album/Torrent name: - +
    Record label: - +
    Catalogue number: - + Year: - +
    Edition title: - + Edition year: - +
    Edition release label: - +
    Edition catalogue number: - +
    File list: - +
    Torrent description: - +
    Search terms: - +
    Tags (comma-separated): -   +   />   /> - +
    Tags: -   +   />   />
    Email:Email address: Email address
    - +

    When changing your email address, you must enter your current password in the "Current password" field before saving your changes.

    Email address: - +
    - + diff --git a/sections/wiki/article.php b/sections/wiki/article.php index fef9f03d..0c0dbb8a 100644 --- a/sections/wiki/article.php +++ b/sections/wiki/article.php @@ -63,11 +63,7 @@
    - +
    diff --git a/sections/wiki/search.php b/sections/wiki/search.php index 333693f0..93efdcaa 100644 --- a/sections/wiki/search.php +++ b/sections/wiki/search.php @@ -85,7 +85,7 @@
    diff --git a/sections/wiki/splash.php b/sections/wiki/splash.php index e8193343..120b931f 100644 --- a/sections/wiki/splash.php +++ b/sections/wiki/splash.php @@ -7,7 +7,7 @@

    Search the wiki for user created tutorials and information.

    - +
    @@ -42,4 +42,4 @@ - \ No newline at end of file + diff --git a/sections/wiki/wiki_browse.php b/sections/wiki/wiki_browse.php index 41c557d4..90281ab1 100644 --- a/sections/wiki/wiki_browse.php +++ b/sections/wiki/wiki_browse.php @@ -53,7 +53,7 @@ - +
    EmailEmail address Expires in Delete invite
    - +