From 3ab563f314cb5981dbc6f79a42e757c345087d77 Mon Sep 17 00:00:00 2001
From: Viktor Lofgren <vlofgren@marginalia.nu>
Date: Fri, 19 Apr 2024 13:58:28 +0200
Subject: [PATCH] (ranking) Suppress NaN:s in ranking output

---
 .../nu/marginalia/ranking/results/ResultValuator.java | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/code/index/java/nu/marginalia/ranking/results/ResultValuator.java b/code/index/java/nu/marginalia/ranking/results/ResultValuator.java
index a389c8c9..4f149c4d 100644
--- a/code/index/java/nu/marginalia/ranking/results/ResultValuator.java
+++ b/code/index/java/nu/marginalia/ranking/results/ResultValuator.java
@@ -124,11 +124,20 @@ public class ResultValuator {
 
         // Renormalize to 0...15, where 0 is the best possible score;
         // this is a historical artifact of the original ranking function
-        return normalize(
+        double ret = normalize(
                       tcfOverlap + tcfJaccard
                       + bM25F + bM25P + bM25N
                       + overallPartPositive,
                 overallPartNegative);
+
+        if (Double.isNaN(ret)) {
+            if (getClass().desiredAssertionStatus()) {
+                throw new IllegalStateException("NaN in result value calculation");
+            }
+
+            return Double.MAX_VALUE;
+        }
+        return ret;
     }
 
     private double calculateQualityPenalty(int size, int quality, ResultRankingParameters rankingParams) {