(ranking) Cleanup

This commit is contained in:
Viktor Lofgren 2024-04-19 14:13:12 +02:00
parent f623b37577
commit 4489b21528
3 changed files with 8 additions and 13 deletions

View File

@ -19,14 +19,4 @@ public class SearchResultSet {
return results.size();
}
public static SearchResultSet combine(SearchResultSet l, SearchResultSet r) {
List<DecoratedSearchResultItem> combinedItems = new ArrayList<>(l.size() + r.size());
combinedItems.addAll(l.results);
combinedItems.addAll(r.results);
// TODO: Do we combine these correctly?
combinedItems.sort(Comparator.comparing(item -> item.rankingScore));
return new SearchResultSet(combinedItems);
}
}

View File

@ -53,7 +53,7 @@ public class QueryGRPCService extends QueryApiGrpc.QueryApiImplBase {
Integer.toString(request.getQueryLimits().getResultsTotal()))
.time(() -> {
var params = QueryProtobufCodec.convertRequest(request);
var query = queryFactory.createQuery(params, null);
var query = queryFactory.createQuery(params, ResultRankingParameters.sensibleDefaults());
RpcIndexQuery indexRequest = QueryProtobufCodec.convertQuery(request, query);
List<RpcDecoratedResultItem> bestItems = executeQueries(indexRequest, request.getQueryLimits().getResultsTotal());
@ -109,7 +109,10 @@ public class QueryGRPCService extends QueryApiGrpc.QueryApiImplBase {
results.sort(comparator);
results.removeIf(this::isBlacklisted);
return results.subList(0, Math.min(totalSize, results.size()));
if (results.size() > totalSize) {
results = results.subList(0, totalSize);
}
return results;
}
}

View File

@ -137,7 +137,9 @@ public class ResultValuator {
return Double.MAX_VALUE;
}
return ret;
else {
return ret;
}
}
private double calculateQualityPenalty(int size, int quality, ResultRankingParameters rankingParams) {