From c47eb2548327fe58b1287db0621e4828e1310449 Mon Sep 17 00:00:00 2001 From: Viktor Lofgren Date: Tue, 7 Mar 2023 16:38:33 +0100 Subject: [PATCH] Remove refuse pile logic that in practice resulted in a lot fewer results showing up for many queries. --- .../nu/marginalia/index/svc/IndexQueryService.java | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/services-core/index-service/src/main/java/nu/marginalia/index/svc/IndexQueryService.java b/services-core/index-service/src/main/java/nu/marginalia/index/svc/IndexQueryService.java index 518071a6..ffd6331d 100644 --- a/services-core/index-service/src/main/java/nu/marginalia/index/svc/IndexQueryService.java +++ b/services-core/index-service/src/main/java/nu/marginalia/index/svc/IndexQueryService.java @@ -181,7 +181,6 @@ public class IndexQueryService { params.queryParams); ArrayList items = new ArrayList<>(results.size()); - ArrayList refusedItems = new ArrayList<>(results.size()); // Sorting the result ids results in better paging characteristics results.sort(); @@ -189,21 +188,11 @@ public class IndexQueryService { results.forEach(id -> { var item = evaluator.evaluateResult(id); - // Score value is zero when the best params variant consists of low-value terms that are just scattered - // throughout the document, with no indicators of importance associated with them. - if (item.getScoreValue() < 0) { - items.add(item); - } - else { - refusedItems.add(item); - } + items.add(item); return true; }); - if (items.isEmpty()) { - items.addAll(refusedItems); - } return items; }