From c5dbe269f716f780e5cffb87166d72394c34e52c Mon Sep 17 00:00:00 2001 From: vlofgren Date: Sun, 17 Jul 2022 15:17:39 +0200 Subject: [PATCH] Better logging for URL errors --- .../marginalia/wmsa/edge/converting/loader/SqlLoadUrls.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/marginalia_nu/src/main/java/nu/marginalia/wmsa/edge/converting/loader/SqlLoadUrls.java b/marginalia_nu/src/main/java/nu/marginalia/wmsa/edge/converting/loader/SqlLoadUrls.java index d09fac4a..a3fd2797 100644 --- a/marginalia_nu/src/main/java/nu/marginalia/wmsa/edge/converting/loader/SqlLoadUrls.java +++ b/marginalia_nu/src/main/java/nu/marginalia/wmsa/edge/converting/loader/SqlLoadUrls.java @@ -53,6 +53,10 @@ public class SqlLoadUrls { { conn.setAutoCommit(false); for (var url : urls) { + if (url.path.length() >= 255) { + logger.warn("Skipping bad URL {}", url); + continue; + } insertCall.setString(1, url.proto); insertCall.setString(2, url.domain.toString()); @@ -68,7 +72,7 @@ public class SqlLoadUrls { insertCall.addBatch(); } var ret = insertCall.executeBatch(); - for (int rv = 0; rv < urls.length; rv++) { + for (int rv = 0; rv < ret.length; rv++) { if (ret[rv] < 0 && ret[rv] != SUCCESS_NO_INFO) { logger.warn("load({}) -- bad row count {}", urls[rv], ret[rv]); }