Mirror/MarginaliaSearch
1
0
Fork 0
mirror of https://github.com/MarginaliaSearch/MarginaliaSearch.git synced 2025-02-24 05:18:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix bug in dealing with scheme-relative URLs

Browse Source
This commit is contained in:
Viktor Lofgren 2023-01-19 15:46:32 +01:00
parent 321a9028c7
commit c8f7a8cb69
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
marginalia_nu/src/main/java/nu/marginalia/wmsa/edge/converting/processor/logic/LinkParser.java
View File

@ -126,6 +126,9 @@ public class LinkParser {
if (doesUrlStringHaveProtocol(s)) { if (doesUrlStringHaveProtocol(s)) {
return s; return s;
} }
else if (s.startsWith("//")) { // scheme-relative URL
return baseUrl.proto + ":" + s;
}
String[] parts = paramSeparatorPattern.split(s, 2); String[] parts = paramSeparatorPattern.split(s, 2);
String path = parts[0]; String path = parts[0];

1
marginalia_nu/src/test/java/nu/marginalia/wmsa/edge/crawling/LinkParserTest.java
View File

@ -45,6 +45,7 @@ class LinkParserTest {
@Test @Test
void testRelative() throws URISyntaxException { void testRelative() throws URISyntaxException {
assertEquals("http://search.marginalia.nu/", parseLink("//search.marginalia.nu", "/"));
assertEquals("http://www.marginalia.nu/test", parseLink("../test", "/")); assertEquals("http://www.marginalia.nu/test", parseLink("../test", "/"));
assertEquals("http://www.marginalia.nu/test", parseLink("test", "/")); assertEquals("http://www.marginalia.nu/test", parseLink("test", "/"));
assertEquals("http://www.marginalia.nu/foo/test", parseLink("test", "/foo/index.html")); assertEquals("http://www.marginalia.nu/foo/test", parseLink("test", "/foo/index.html"));