From c91435e314425670dcc861de91579af215856963 Mon Sep 17 00:00:00 2001 From: Viktor Lofgren Date: Fri, 27 Sep 2024 14:08:08 +0200 Subject: [PATCH] (assistant) Don't attempt to respond to similarity and linkedness queries before the data is ready This will reduce the number of exceptions in the assistant logs quite significantly. --- .../domains/DomainInfoGrpcService.java | 21 ++++++++++++------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/code/functions/domain-info/java/nu/marginalia/functions/domains/DomainInfoGrpcService.java b/code/functions/domain-info/java/nu/marginalia/functions/domains/DomainInfoGrpcService.java index a39cb033..04663f43 100644 --- a/code/functions/domain-info/java/nu/marginalia/functions/domains/DomainInfoGrpcService.java +++ b/code/functions/domain-info/java/nu/marginalia/functions/domains/DomainInfoGrpcService.java @@ -32,11 +32,15 @@ public class DomainInfoGrpcService @Override public void getSimilarDomains(RpcDomainLinksRequest request, StreamObserver responseObserver) { - var ret = similarDomainsService.getSimilarDomains(request.getDomainId(), request.getCount()); - var responseBuilder = RpcSimilarDomains - .newBuilder() - .addAllDomains(ret); + + var responseBuilder = RpcSimilarDomains.newBuilder(); + + if (similarDomainsService.isReady()) { + var ret = similarDomainsService.getSimilarDomains(request.getDomainId(), request.getCount()); + responseBuilder.addAllDomains(ret); + } + responseObserver.onNext(responseBuilder.build()); responseObserver.onCompleted(); @@ -44,11 +48,12 @@ public class DomainInfoGrpcService @Override public void getLinkingDomains(RpcDomainLinksRequest request, StreamObserver responseObserver) { - var ret = similarDomainsService.getLinkingDomains(request.getDomainId(), request.getCount()); + var responseBuilder = RpcSimilarDomains.newBuilder(); - var responseBuilder = RpcSimilarDomains - .newBuilder() - .addAllDomains(ret); + if (similarDomainsService.isReady()) { + var ret = similarDomainsService.getLinkingDomains(request.getDomainId(), request.getCount()); + responseBuilder.addAllDomains(ret); + } responseObserver.onNext(responseBuilder.build()); responseObserver.onCompleted();