YAGNI filter over ConverterDomainTypes

This commit is contained in:
Viktor Lofgren 2023-07-31 10:32:47 +02:00
parent 9786f82220
commit cd90ca820f

View File

@ -9,8 +9,8 @@ import org.slf4j.LoggerFactory;
import java.io.IOException; import java.io.IOException;
import java.sql.SQLException; import java.sql.SQLException;
import java.util.HashMap; import java.util.HashSet;
import java.util.Map; import java.util.Set;
/** Converter-side wrapper for of common:db's DomainTypes, /** Converter-side wrapper for of common:db's DomainTypes,
* which is a list of domains of a known type (e.g. blog) * which is a list of domains of a known type (e.g. blog)
@ -18,11 +18,7 @@ import java.util.Map;
@Singleton @Singleton
public class ConverterDomainTypes { public class ConverterDomainTypes {
private final Logger logger = LoggerFactory.getLogger(ConverterDomainTypes.class); private final Logger logger = LoggerFactory.getLogger(ConverterDomainTypes.class);
private final Map<EdgeDomain, DomainType> domainTypes = new HashMap<>(); private final Set<EdgeDomain> blogs = new HashSet<>(10000, 0.5f);
private enum DomainType {
BLOG
}
@Inject @Inject
public ConverterDomainTypes(DomainTypes types) throws SQLException { public ConverterDomainTypes(DomainTypes types) throws SQLException {
@ -40,14 +36,13 @@ public class ConverterDomainTypes {
} }
for (var item : allBlogs) { for (var item : allBlogs) {
domainTypes.put(new EdgeDomain(item), DomainType.BLOG); blogs.add(new EdgeDomain(item));
} }
logger.info("Loaded {} domain types", domainTypes.size()); logger.info("Loaded {} domain types", blogs.size());
} }
public boolean isBlog(EdgeDomain domain) { public boolean isBlog(EdgeDomain domain) {
return domainTypes.get(domain) == DomainType.BLOG; return blogs.contains(domain);
} }
} }