Mirror/bittorrent-tracker
1
0
Fork 0
mirror of https://github.com/webtorrent/bittorrent-tracker.git synced 2024-12-14 03:16:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

use delete obj[key] instead of obj[key] = null

Browse Source
This commit is contained in:
Feross Aboukhadijeh 2016-03-10 21:26:28 -08:00
parent 32c2e985fd
commit 0585d8b18a
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/client/websocket-tracker.js
View File

@ -70,7 +70,7 @@ WebSocketTracker.prototype.destroy = function (onclose) {
self.destroyed = true self.destroyed = true
clearInterval(self.interval) clearInterval(self.interval)
socketPool[self.announceUrl] = null delete socketPool[self.announceUrl]
self.socket.removeListener('connect', self._onSocketConnectBound) self.socket.removeListener('connect', self._onSocketConnectBound)
self.socket.removeListener('data', self._onSocketDataBound) self.socket.removeListener('data', self._onSocketDataBound)
@ -208,7 +208,7 @@ WebSocketTracker.prototype._onSocketData = function (data) {
clearTimeout(peer.trackerTimeout) clearTimeout(peer.trackerTimeout)
peer.trackerTimeout = null peer.trackerTimeout = null
self.peers[offerId] = null delete self.peers[offerId]
} else { } else {
debug('got unexpected answer: ' + JSON.stringify(data.answer)) debug('got unexpected answer: ' + JSON.stringify(data.answer))
} }
@ -281,7 +281,7 @@ WebSocketTracker.prototype._generateOffers = function (numwant, cb) {
peer.trackerTimeout = setTimeout(function () { peer.trackerTimeout = setTimeout(function () {
debug('tracker timeout: destroying peer') debug('tracker timeout: destroying peer')
peer.trackerTimeout = null peer.trackerTimeout = null
self.peers[offerId] = null delete self.peers[offerId]
peer.destroy() peer.destroy()
}, OFFER_TIMEOUT) }, OFFER_TIMEOUT)
} }

1
lib/server/swarm.js
View File

@ -103,7 +103,6 @@ Swarm.prototype._getPeers = function (numwant, ownPeerId, isWebRTC) {
var peerId var peerId
while ((peerId = ite()) && peers.length < numwant) { while ((peerId = ite()) && peers.length < numwant) {
var peer = this.peers[peerId] var peer = this.peers[peerId]
if (!peer) continue
if (isWebRTC && peer.peerId === ownPeerId) continue // don't send peer to itself if (isWebRTC && peer.peerId === ownPeerId) continue // don't send peer to itself
if ((isWebRTC && peer.ip) || (!isWebRTC && peer.socket)) continue // send proper peer type if ((isWebRTC && peer.ip) || (!isWebRTC && peer.socket)) continue // send proper peer type
peers.push(peer) peers.push(peer)