Commit Graph

913 Commits

Author SHA1 Message Date
Feross Aboukhadijeh
a469740603 Merge pull request #198 from feross/fix-196
Fix stats and leaked websockets
2017-02-09 23:16:28 +01:00
Feross Aboukhadijeh
da7d7323df 8.3.1 2017-02-09 14:14:10 -08:00
Feross Aboukhadijeh
b3103181fa Merge pull request #201 from feross/disable-clientTracking
Disable ws server clientTracking
2017-02-09 23:13:14 +01:00
Feross Aboukhadijeh
3d81e68124 standard 2017-02-08 16:22:13 -08:00
Diego Rodríguez Baquero
7fea1964af Update server.js 2017-02-08 16:53:50 -05:00
Diego Rodríguez Baquero
a1ee19d59a Set ws server clientTracking to false
https://github.com/feross/bittorrent-tracker/pull/200#issuecomment-278450630
2017-02-08 16:47:54 -05:00
Feross Aboukhadijeh
3f3db7deb1 client: socketPool should not be shared across clients
Caught this issue because of the new eviction tests. Essentially, this
change moves the socketPool into the client instance instead of a
reused variable at the module level.

When a client sends stop (or is evicted) the server will close the
websocket connection if that client is not in any other swarms (based
on peerId). However, if we are using a single socket for multiple
clients (as was the case before this commit), then other clients will
have their sockets unintentionally closed by the server.
2017-02-08 13:20:41 -08:00
Feross Aboukhadijeh
806ce1d18b Address @DiegoRBaquero's feedback
From comment:
https://github.com/feross/bittorrent-tracker/pull/198#discussion_r993882
95
2017-02-08 13:13:20 -08:00
Feross Aboukhadijeh
cd4a976121 add failing tests for desired evicition behavior 2017-02-08 13:12:39 -08:00
Feross Aboukhadijeh
4422067607 test: server: check that all clients, server are destroyed 2017-02-08 13:11:48 -08:00
Feross Aboukhadijeh
e731106279 test: ensure electron-webrtc is started only for test where it's needed
before this change, it was getting initialized immediately, since it
was outside a tape test block
2017-02-08 13:11:35 -08:00
Feross Aboukhadijeh
d534582a8c Only close websocket when it's not participating in any more swarms 2017-02-08 12:27:50 -08:00
Feross Aboukhadijeh
29d4564bbd remove unneeded timeout 2017-02-08 12:27:50 -08:00
Feross Aboukhadijeh
1b22b53fe8 fix tests: wait for socket to send final responses 2017-02-08 12:27:50 -08:00
Feross Aboukhadijeh
7075088848 Close websockets when peers are evicted from LRU cache
Possibly fixes: https://github.com/feross/bittorrent-tracker/issues/196

Close websockets when peers are evicted from LRU cache, otherwise it's
possible for a peer object to be evicted from the LRU cache without the
socket being cleaned up. That will leak memory until the websocket is
closed by the remote client. It also messes up the stats.
2017-02-08 12:27:50 -08:00
Feross Aboukhadijeh
8f33b95f9f swarm maxAge: increase to 20 min 2017-02-08 12:27:50 -08:00
Feross Aboukhadijeh
6351f2b260 style: re-order methods 2017-02-08 12:27:50 -08:00
Feross Aboukhadijeh
62dd0f7df2 treat unexpected 'completed' events as 'updated' 2017-02-08 12:27:50 -08:00
Feross Aboukhadijeh
ed3da2f39b If peer is already complete, it should still be refreshed in the LRU cache 2017-02-08 12:27:50 -08:00
Feross Aboukhadijeh
c2c8e36af7 Fix bug where left = 0 would be converted to Infinity
Possibly fixes: https://github.com/feross/bittorrent-tracker/issues/196
2017-02-08 12:27:50 -08:00
Feross Aboukhadijeh
27ae148167 Fixes for PR #185 2017-02-08 12:27:50 -08:00
Feross Aboukhadijeh
76165007ba 8.3.0 2017-02-08 10:56:31 -08:00
Diego Rodríguez Baquero
4c86e98e44 Merge pull request #200 from feross/disable-deflate
perf: disable perMessageDeflate
2017-02-08 11:04:10 -05:00
Feross Aboukhadijeh
71bd413980 perf: disable perMessageDeflate
From the ws docs:

"ws supports the permessage-deflate extension extension which enables
the client and server to negotiate a compression algorithm and its
parameters, and then selectively apply it to the data payloads of each
WebSocket message.

The extension is enabled by default but adds a significant overhead in
terms of performance and memory comsumption. We suggest to use
WebSocket compression only if it is really needed.

To disable the extension you can set the perMessageDeflate option to
false"
2017-02-07 23:00:10 -08:00
Feross Aboukhadijeh
9d5b55b498 Merge pull request #197 from feross/fewer-offers
ws client: Don't include offers with 'completed' event
2017-02-03 23:46:20 +01:00
Feross Aboukhadijeh
30b6f176b1 ws client: Don't include offers with 'completed' event
It's not necessary to include webrtc offers because the client is not
really looking for more peers when it has just completed the torrent.

Fewer WebRTC offers = less resource usage
2017-02-02 16:59:36 -08:00
Feross Aboukhadijeh
fb751d7c96 Re-enable ws server tests (websocket tracker) 2017-01-29 16:25:16 -08:00
Feross Aboukhadijeh
2cb749d739 minor style 2017-01-29 15:37:22 -08:00
Feross Aboukhadijeh
0f57bfcd28 8.2.0 2017-01-23 15:00:31 -08:00
Feross Aboukhadijeh
3b463e4dbf Merge pull request #194 from feross/final-wait
Wait up to 1s for pending requests before destroy()
2017-01-23 14:59:19 -08:00
Feross Aboukhadijeh
0aadcc1cbb Wait up to 1s for pending requests before destroy()
If the user calls:

client.stop()
client.destroy()

We should ensure that the final 'stopped' message reaches the tracker
server, even though the client will not get the response (because they
destroyed the client and no more events will be emitted).

If there are pending requests when destroy() is called, then a 1s timer
is set after which point all requests are forcibly cleaned up. If the
requests complete before the 1s timer fires, then cleanup happens right
away (so we're not stuck waiting for the 1s timer).

So, destroy() can happen one of three ways:

- immediately, if no pending requests exist
- after exactly 1s, if pending requests exist and they don't complete
within 1s
- less than 1s, if pending requests exist and they all complete before
the 1s timer fires
2017-01-20 18:41:28 -08:00
Feross Aboukhadijeh
9cf2dffa67 debug: better debug names 2017-01-20 18:34:33 -08:00
Feross Aboukhadijeh
c3bf7f87f6 test: add failing test for the second part of #190 2017-01-20 18:34:05 -08:00
Feross Aboukhadijeh
63d24611ec test: speed up testClientUpdate() test 2017-01-20 18:33:30 -08:00
Feross Aboukhadijeh
1424a00c3a test: don't rely on setTimeout in testClientStop() 2017-01-20 18:33:17 -08:00
Feross Aboukhadijeh
ee45b7947b update filter tests to clarify multiple clients 2017-01-20 18:32:59 -08:00
Feross Aboukhadijeh
e5812fdd29 electron-webrtc@0.3 2017-01-20 15:20:25 -08:00
Feross Aboukhadijeh
bae84372f3 authors 2017-01-16 15:44:17 -08:00
Feross Aboukhadijeh
dea66d1b3e 8.1.0 2017-01-16 15:44:11 -08:00
Feross Aboukhadijeh
c4f4f012dd Add fixes and tests for PR #179 2017-01-16 15:43:47 -08:00
Feross Aboukhadijeh
91cb2d3439 Merge pull request #179 from zunsthy/feature-add-user-agent
add 'user-agent' in HTTP header
2017-01-16 15:20:11 -08:00
Feross Aboukhadijeh
563c55bd71 AUTHORS 2017-01-16 14:52:27 -08:00
Feross Aboukhadijeh
437b4fb5f7 8.0.14 2017-01-16 14:39:19 -08:00
Feross Aboukhadijeh
c454bdec87 Merge pull request #191 from feross/dep
bencode@0.11
2017-01-16 14:38:18 -08:00
Feross Aboukhadijeh
714d91e0ca bencode@0.11 2017-01-16 14:36:01 -08:00
Feross Aboukhadijeh
e4e680bfc5 Merge pull request #188 from vijayanandnandam/master
Fixes documentation in readme for multiscrape api
2017-01-16 05:07:01 -08:00
vijayanand nandam
cde079c419 fixes documentation in readme for multiscrape api 2017-01-08 16:08:11 +05:30
Feross Aboukhadijeh
a727fd9012 8.0.13 2016-12-04 17:09:20 -08:00
Feross Aboukhadijeh
a32ae8f1b4 Merge pull request #185 from sidd/master
Fix issue where seeders improperly marked as leechers
2016-12-04 17:07:38 -08:00
Sidd Sridharan
9d9893a0f2 parse params.left = 0 properly 2016-12-04 12:42:57 -08:00