Mirror/filesafe
1
0
Fork 0
mirror of https://github.com/BobbyWibowo/lolisafe.git synced 2025-01-31 07:11:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

feat: timeout url uploads to 10s

Browse Source 
uwebsockets.js has a 10s timeout of no communication between client and
server, for it to simply drop the connection

there's no point waiting any further at that point since we can't reply
to client anymore
This commit is contained in:
Bobby 2022-08-24 04:37:13 +07:00
parent 6ad8ed7ae6
commit 3df67f87be
No known key found for this signature in database
GPG Key ID: 941839794CBF5A09
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
controllers/uploadController.js
View File

@ -567,7 +567,12 @@ self.actuallyUploadUrls = async (req, res, data = {}) => {
// Try to determine size early via Content-Length header,
// but continue anyway if it isn't a valid number
try {
const head = await fetch(url, { method: 'HEAD', size: urlMaxSizeBytes })
const head = await fetch(url, {
method: 'HEAD',
size: urlMaxSizeBytes, // limit max response body size
timeout: 10 * 1000 // 10 seconds
})
if (head.status === 200) {
const contentLength = parseInt(head.headers.get('content-length'))
if (!Number.isNaN(contentLength)) {
@ -595,8 +600,11 @@ self.actuallyUploadUrls = async (req, res, data = {}) => {
writeStream = fs.createWriteStream(file.path)
hashStream = enableHashing && blake3.createHash()
// Limit max response body size with maximum allowed size
const fetchFile = await fetch(url, { method: 'GET', size: urlMaxSizeBytes })
const fetchFile = await fetch(url, {
method: 'GET',
size: urlMaxSizeBytes, // limit max response body size
timeout: 10 * 1000 // 10 seconds
})
.then(res => new Promise((resolve, reject) => {
if (res.status !== 200) {
return resolve(res)
@ -696,6 +704,7 @@ self.actuallyUploadUrls = async (req, res, data = {}) => {
// Re-throw suppressed errors as ClientError, otherwise as-is
const errorString = error.toString()
const suppress = [
/ network timeout at:/,
/ over limit:/
]
if (suppress.some(t => t.test(errorString))) {