refactor: Client/ServerError on tokenController

This commit is contained in:
Bobby Wibowo 2021-01-08 10:56:09 +07:00
parent a5607c00f6
commit 452542ca36
No known key found for this signature in database
GPG Key ID: 51C3A1E1E22D26CF

View File

@ -1,8 +1,10 @@
const randomstring = require('randomstring') const randomstring = require('randomstring')
const perms = require('./permissionController') const perms = require('./permissionController')
const utils = require('./utilsController') const utils = require('./utilsController')
const apiErrorsHandler = require('./handlers/apiErrorsHandler')
const ClientError = require('./utils/ClientError')
const ServerError = require('./utils/ServerError')
const config = require('./../config') const config = require('./../config')
const logger = require('./../logger')
const db = require('knex')(config.database) const db = require('knex')(config.database)
const self = { const self = {
@ -35,52 +37,54 @@ self.generateUniqueToken = async () => {
} }
self.verify = async (req, res, next) => { self.verify = async (req, res, next) => {
const token = typeof req.body.token === 'string'
? req.body.token.trim()
: ''
if (!token) return res.json({ success: false, description: 'No token provided.' })
try { try {
const token = typeof req.body.token === 'string'
? req.body.token.trim()
: ''
if (!token) throw new ClientError('No token provided.', { statusCode: 403 })
const user = await db.table('users') const user = await db.table('users')
.where('token', token) .where('token', token)
.select('username', 'permission') .select('username', 'permission')
.first() .first()
if (!user) return res.json({ success: false, description: 'Invalid token.' }) if (!user) throw new ClientError('Invalid token.', { statusCode: 403 })
const obj = { const obj = {
success: true, success: true,
username: user.username, username: user.username,
permissions: perms.mapPermissions(user) permissions: perms.mapPermissions(user)
} }
if (utils.clientVersion) obj.version = utils.clientVersion
return res.json(obj) if (utils.clientVersion) {
obj.version = utils.clientVersion
}
await res.json(obj)
} catch (error) { } catch (error) {
logger.error(error) return apiErrorsHandler(error, req, res, next)
return res.status(500).json({ success: false, description: 'An unexpected error occurred. Try again?' })
} }
} }
self.list = async (req, res, next) => { self.list = async (req, res, next) => {
const user = await utils.authorize(req, res) try {
if (!user) return const user = await utils.authorize(req)
return res.json({ success: true, token: user.token }) await res.json({ success: true, token: user.token })
} catch (error) {
return apiErrorsHandler(error, req, res, next)
}
} }
self.change = async (req, res, next) => { self.change = async (req, res, next) => {
const user = await utils.authorize(req, res)
if (!user) return
const newToken = await self.generateUniqueToken()
if (!newToken) {
return res.json({
success: false,
description: 'Sorry, we could not allocate a unique token. Try again?'
})
}
try { try {
const user = await utils.authorize(req)
const newToken = await self.generateUniqueToken()
if (!newToken) {
throw new ServerError('Failed to allocate a unique token. Try again?')
}
await db.table('users') await db.table('users')
.where('token', user.token) .where('token', user.token)
.update({ .update({
@ -89,13 +93,9 @@ self.change = async (req, res, next) => {
}) })
self.onHold.delete(newToken) self.onHold.delete(newToken)
return res.json({ await res.json({ success: true, token: newToken })
success: true,
token: newToken
})
} catch (error) { } catch (error) {
logger.error(error) return apiErrorsHandler(error, req, res, next)
return res.status(500).json({ success: false, description: 'An unexpected error occurred. Try again?' })
} }
} }