From 83eb4872e9b3377c1b2d01d2475e4eb11b0d9457 Mon Sep 17 00:00:00 2001
From: Bobby Wibowo <bobbywibowo98@gmail.com>
Date: Sun, 21 Jul 2019 05:15:59 +0700
Subject: [PATCH] Updated utilsController.js

* Simplified some logics.

* Try to unlink thumbnail when failing to generate video thumbnail,
since ffmpeg may have already created an incomplete thumbnail.
---
 controllers/utilsController.js | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/controllers/utilsController.js b/controllers/utilsController.js
index a64ca3e..26f5ba9 100644
--- a/controllers/utilsController.js
+++ b/controllers/utilsController.js
@@ -165,17 +165,17 @@ utilsController.generateThumbs = (name, force) => {
 
       if (!error && stats.isSymbolicLink()) {
         // Unlink symlink
-        const unlink = await new Promise((resolve, reject) => {
+        const unlink = await new Promise(resolve => {
           fs.unlink(thumbname, error => {
-            if (error) return reject(error)
-            return resolve(true)
+            if (error) console.error(error)
+            resolve(!error)
           })
-        }).catch(console.error)
+        })
         if (!unlink) return resolve(false)
       }
 
       // Only make thumbnail if it does not exist (ENOENT)
-      if (!error && !stats.isSymbolicLink() && !force) return resolve(true)
+      if (!error && !force) return resolve(true)
 
       // Full path to input file
       const input = path.join(__dirname, '..', config.uploads.folder, name)
@@ -235,7 +235,15 @@ utilsController.generateThumbs = (name, force) => {
               '-vframes 1',
               '-vf scale=200:200:force_original_aspect_ratio=decrease'
             ])
-            .on('error', reject)
+            .on('error', error => {
+              // Attempt to unlink thumbnail
+              // Since ffmpeg may have already created an incomplete thumbnail
+              fs.unlink(thumbname, err => {
+                if (err && err.code !== 'ENOENT')
+                  console.error(`${name}: ${err.toString()}`)
+                reject(error)
+              })
+            })
             .on('end', () => resolve(true))
             .run()
         })