Mirror/filesafe
1
0
Fork 0
mirror of https://github.com/BobbyWibowo/lolisafe.git synced 2025-01-19 09:41:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: handle connection drop on multiform upload

Browse Source
This commit is contained in:
Bobby 2022-07-15 01:40:57 +07:00
parent 27f3bc3119
commit e6753ab15d
No known key found for this signature in database
GPG Key ID: 941839794CBF5A09
1 changed files with 18 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
controllers/uploadController.js
View File

@ -221,6 +221,13 @@ self.upload = async (req, res) => {
// Initially try to parse as multipart // Initially try to parse as multipart
let hasMultipartField = true let hasMultipartField = true
const unlinkFiles = async files => {
return Promise.all(files.map(async file => {
if (!file.filename) return
return utils.unlinkFile(file.filename).catch(logger.error)
}))
}
await req.multipart({ await req.multipart({
// https://github.com/mscdex/busboy/tree/v1.6.0#exports // https://github.com/mscdex/busboy/tree/v1.6.0#exports
limits: { limits: {
@ -396,12 +403,8 @@ self.upload = async (req, res) => {
} }
}).catch(error => { }).catch(error => {
// Unlink temp files (do not wait) // Unlink temp files (do not wait)
if (Array.isArray(req.files)) { if (Array.isArray(req.files) && req.files.length) {
Promise.all(req.files.map(async file => { unlinkFiles(req.files)
if (file.filename) {
return utils.unlinkFile(file.filename).catch(logger.error)
}
}))
} }
// res.multipart() itself may throw string errors // res.multipart() itself may throw string errors
@ -412,12 +415,16 @@ self.upload = async (req, res) => {
} }
}) })
// If Request connection dropped during multiform upload
if (req._readableState.closed) {
return
}
if (hasMultipartField) { if (hasMultipartField) {
if (!Array.isArray(req.files) || !req.files.length) {
throw new ClientError('No files.')
} else if (req.files.some(file => file.error)) {
// Unlink temp files (do not wait)
unlinkFiles(req.files)
// If req.multipart() did not error out, but some file object did,
// then Request connection was likely dropped
return
}
return self.actuallyUpload(req, res, user) return self.actuallyUpload(req, res, user)
} else { } else {
// Parse POST body // Parse POST body
@ -427,10 +434,6 @@ self.upload = async (req, res) => {
} }
self.actuallyUpload = async (req, res, user, data = {}) => { self.actuallyUpload = async (req, res, user, data = {}) => {
if (!req.files || !req.files.length) {
throw new ClientError('No files.')
}
// If chunked uploads is enabled and the uploaded file is a chunk, then just say that it was a success // If chunked uploads is enabled and the uploaded file is a chunk, then just say that it was a success
const uuid = req.body.uuid const uuid = req.body.uuid
if (chunkedUploads && chunksData[uuid] !== undefined) { if (chunkedUploads && chunksData[uuid] !== undefined) {