From 5728c66cca92093b14ef25cedca81977afa90613 Mon Sep 17 00:00:00 2001
From: Reckless_Satoshi <reckless.satoshi@protonmail.com>
Date: Wed, 10 May 2023 12:07:28 -0700
Subject: [PATCH] Add soft time limits to tasks

---
 api/tasks.py | 33 ++++++++++++++++++++++++++++-----
 api/utils.py |  3 ++-
 2 files changed, 30 insertions(+), 6 deletions(-)

diff --git a/api/tasks.py b/api/tasks.py
index 587b1204..97ad3fd8 100644
--- a/api/tasks.py
+++ b/api/tasks.py
@@ -1,4 +1,5 @@
 from celery import shared_task
+from celery.exceptions import SoftTimeLimitExceeded
 
 
 @shared_task(name="users_cleansing", time_limit=600)
@@ -46,7 +47,7 @@ def users_cleansing():
     return results
 
 
-@shared_task(name="follow_send_payment", time_limit=180)
+@shared_task(name="follow_send_payment", time_limit=180, soft_time_limit=175)
 def follow_send_payment(hash):
     """Sends sats to buyer, continuous update"""
 
@@ -68,8 +69,18 @@ def follow_send_payment(hash):
         float(lnpayment.num_satoshis) * float(lnpayment.routing_budget_ppm) / 1_000_000
     )
     timeout_seconds = config("PAYOUT_TIMEOUT_SECONDS", cast=int, default=90)
+    try:
+        results = LNNode.follow_send_payment(lnpayment, fee_limit_sat, timeout_seconds)
+
+    except SoftTimeLimitExceeded:
+        # If the 3 minutes have been consumed without follow_send_payment()
+        # finishing (failed/successful) we set the last routing time as 'now'
+        # so the next check happens in 3 minutes, instead of right now.
+        lnpayment.last_routing_time = timezone.now()
+        lnpayment.save(update_fields=["last_routing_time"])
+        print(f"Order: {lnpayment.order_paid_LN} SOFT TIME LIMIT REACHED. Hash: {hash}")
+        results = {}
 
-    results = LNNode.follow_send_payment(lnpayment, fee_limit_sat, timeout_seconds)
     return results
 
 
@@ -135,16 +146,28 @@ def payments_cleansing():
     return results
 
 
-@shared_task(name="cache_external_market_prices", ignore_result=True, time_limit=120)
+@shared_task(
+    name="cache_external_market_prices",
+    ignore_result=True,
+    time_limit=120,
+    soft_time_limit=115,
+)
 def cache_market():
 
+    import math
+
     from django.utils import timezone
 
     from .models import Currency
     from .utils import get_exchange_rates
 
     currency_codes = list(Currency.currency_dict.values())
-    exchange_rates = get_exchange_rates(currency_codes)
+
+    try:
+        exchange_rates = get_exchange_rates(currency_codes)
+    except SoftTimeLimitExceeded:
+        print("SOFT LIMIT REACHED. Could not fetch current external market prices.")
+        return
 
     results = {}
     for i in range(
@@ -155,7 +178,7 @@ def cache_market():
         results[i] = {currency_codes[i], rate}
 
         # Do not update if no new rate was found
-        if str(rate) == "nan":
+        if math.isnan(rate):
             continue
 
         # Create / Update database cached prices
diff --git a/api/utils.py b/api/utils.py
index 1fcbb257..4c0b6a5a 100644
--- a/api/utils.py
+++ b/api/utils.py
@@ -72,7 +72,7 @@ def validate_onchain_address(address):
 market_cache = {}
 
 
-@ring.dict(market_cache, expire=3)  # keeps in cache for 3 seconds
+@ring.dict(market_cache, expire=30)  # keeps in cache for 30 seconds
 def get_exchange_rates(currencies):
     """
     Params: list of currency codes.
@@ -109,6 +109,7 @@ def get_exchange_rates(currencies):
                         yadio_rates.append(np.nan)
                 api_rates.append(yadio_rates)
         except Exception:
+            print(f"Could not fetch BTC prices from {api_url}")
             pass
 
     if len(api_rates) == 0: