Remove refuse pile logic that in practice resulted in a lot fewer results showing up for many queries.

This commit is contained in:
Viktor Lofgren 2023-03-07 16:38:33 +01:00
parent 58fcddedbb
commit c47eb25483

View File

@ -181,7 +181,6 @@ public class IndexQueryService {
params.queryParams); params.queryParams);
ArrayList<EdgeSearchResultItem> items = new ArrayList<>(results.size()); ArrayList<EdgeSearchResultItem> items = new ArrayList<>(results.size());
ArrayList<EdgeSearchResultItem> refusedItems = new ArrayList<>(results.size());
// Sorting the result ids results in better paging characteristics // Sorting the result ids results in better paging characteristics
results.sort(); results.sort();
@ -189,21 +188,11 @@ public class IndexQueryService {
results.forEach(id -> { results.forEach(id -> {
var item = evaluator.evaluateResult(id); var item = evaluator.evaluateResult(id);
// Score value is zero when the best params variant consists of low-value terms that are just scattered items.add(item);
// throughout the document, with no indicators of importance associated with them.
if (item.getScoreValue() < 0) {
items.add(item);
}
else {
refusedItems.add(item);
}
return true; return true;
}); });
if (items.isEmpty()) {
items.addAll(refusedItems);
}
return items; return items;
} }